jugomezv commented on PR #10324: URL: https://github.com/apache/pinot/pull/10324#issuecomment-1445273911
I pulled the change and look at the main metrics we use in our dashboard related with consumption and as expected they don't change them, I will ping the SREs Monday to make sure I did not miss anything. One small suggestion would be to remove _metricKeyName and replace its uses with _clientId as they will be exactly the same after this change, I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
