Jackie-Jiang commented on code in PR #10172:
URL: https://github.com/apache/pinot/pull/10172#discussion_r1119315979
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/AcquireReleaseColumnsSegmentOperator.java:
##########
@@ -81,6 +86,12 @@ public void release() {
_indexSegment.release(_fetchContext);
}
+ @Override
+ public void prepareForExplainPlan(ExplainPlanRows explainPlanRows) {
+ materializeChildOperator();
+ acquire();
Review Comment:
Should acquire happen before materializeChildOperator?
##########
pinot-core/src/main/java/org/apache/pinot/core/common/Operator.java:
##########
@@ -48,6 +48,9 @@
@Nullable
String toExplainString();
+ default void prepareForExplainPlan(ExplainPlanRows explainPlanRows) {
Review Comment:
Ideally we want the operator to directly fill the explain plan, and pass the
plan to the child operators. Do you think it is hard to integrate this change
into this PR? If so, we can add a TODO and make it handled within the operator
in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
