saurabhd336 commented on code in PR #10343:
URL: https://github.com/apache/pinot/pull/10343#discussion_r1119630062
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/DefaultNullValueVirtualColumnProvider.java:
##########
@@ -88,6 +88,11 @@ public ColumnMetadataImpl buildMetadata(VirtualColumnContext
context) {
ColumnMetadataImpl.Builder builder =
getColumnMetadataBuilder(context).setCardinality(1).setHasDictionary(true);
if (context.getFieldSpec().isSingleValueField()) {
builder.setSorted(true);
+
+ if (context.getFieldSpec().getDefaultNullValue() instanceof Comparable) {
Review Comment:
Ack
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/DefaultNullValueVirtualColumnProvider.java:
##########
@@ -88,6 +88,11 @@ public ColumnMetadataImpl buildMetadata(VirtualColumnContext
context) {
ColumnMetadataImpl.Builder builder =
getColumnMetadataBuilder(context).setCardinality(1).setHasDictionary(true);
if (context.getFieldSpec().isSingleValueField()) {
builder.setSorted(true);
+
+ if (context.getFieldSpec().getDefaultNullValue() instanceof Comparable) {
+ builder.setMinValue((Comparable)
context.getFieldSpec().getDefaultNullValue());
+ builder.setMaxValue((Comparable)
context.getFieldSpec().getDefaultNullValue());
+ }
} else {
// When there is no value for a multi-value column, the
maxNumberOfMultiValues and cardinality should be
Review Comment:
Ack. Added for all column types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
