somandal commented on code in PR #10286:
URL: https://github.com/apache/pinot/pull/10286#discussion_r1124017932
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/stage/WindowNode.java:
##########
@@ -79,7 +79,7 @@ public WindowNode(int stageId, List<Window.Group>
windowGroups, List<RexLiteral>
// Frame literals come in the constants from the LogicalWindow and
the bound.getOffset() stores the
// InputRef to the constants array offset by the input array length.
These need to be extracted here and
// set to the bounds.
- validateFrameBounds(windowGroup.lowerBound, windowGroup.upperBound,
windowGroup.isRows);
Review Comment:
done - I renamed it here, and store it as an enum in
`WindowAggregateOperator`. If it's okay I'll create a util to store the enum in
a common place for use in both places later as a followup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
