jtao15 commented on code in PR #10387:
URL: https://github.com/apache/pinot/pull/10387#discussion_r1129945958
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java:
##########
@@ -330,14 +354,18 @@ public List<PinotTaskConfig>
generateTasks(List<TableConfig> tableConfigs) {
// TODO: If there are many small merged segments, we should
merge them again
selectedSegmentsForBucket = new ArrayList<>();
hasUnmergedSegments = false;
+ isAllSegmentsReadyToMerge = true;
bucketStartMs = (startTimeMs / bucketMs) * bucketMs;
bucketEndMs = bucketStartMs + bucketMs;
- if (!isValidBucketEndTime(bucketEndMs, bufferMs,
lowerMergeLevel, mergeRollupTaskMetadata)) {
+ if (!isValidBucketEndTime(bucketEndMs, bufferMs,
lowerMergeLevel, mergeRollupTaskMetadata, isLookBack)) {
break;
}
- if (!isMergedSegment(preSelectedSegment, mergeLevel)) {
+ if (!isMergedSegment(preSelectedSegment, mergeLevel,
sortedMergeLevels)) {
Review Comment:
Actually, this function is not called on both sides of if/else. Github
folded L351-L356, and that may lead to the confusion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
