ankitsultana commented on code in PR #10409:
URL: https://github.com/apache/pinot/pull/10409#discussion_r1132842965
##########
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotQueryRuleSets.java:
##########
@@ -115,4 +116,12 @@ private PinotQueryRuleSets() {
PinotAggregateExchangeNodeInsertRule.INSTANCE,
PinotWindowExchangeNodeInsertRule.INSTANCE
);
+
+ public static final Collection<RelOptRule> FILTER_PUSHDOWN_RULES =
ImmutableList.of(
Review Comment:
todo: by default Calcite will use depth first order for running these rules.
Also it won't do a "fullRestartAfterTransformation" unless we use
HepMatchOrder.TOP_DOWN or HepMatchOrder.BOTTOM_UP.
I think using depth first order without doing full restarts after
transformation should be fine but would be good if someone else also chimes in.
Note that the match order can be changed for only this collection (it's a
HepInstruction) so it doesn't need to be a global setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
