jackjlli commented on code in PR #10412:
URL: https://github.com/apache/pinot/pull/10412#discussion_r1133315178
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java:
##########
@@ -379,26 +379,45 @@ public String forDeleteTableWithType(String tableName,
String tableType) {
}
public String forSegmentListAPI(String tableName) {
- return forSegmentListAPI(tableName, null, false);
+ return forSegmentListAPI(tableName, null, false, Long.MIN_VALUE,
Long.MAX_VALUE, false);
}
public String forSegmentListAPI(String tableName, String tableType) {
- return forSegmentListAPI(tableName, tableType, false);
+ return forSegmentListAPI(tableName, tableType, false, Long.MIN_VALUE,
Long.MAX_VALUE, false);
}
- public String forSegmentListAPI(String tableName, @Nullable String
tableType, boolean excludeReplacedSegments) {
+ public String forSegmentListAPI(String tableName, String tableType, boolean
excludeReplacedSegments) {
+ return forSegmentListAPI(tableName, tableType, excludeReplacedSegments,
Long.MIN_VALUE, Long.MAX_VALUE, false);
+ }
+
+ public String forSegmentListAPI(String tableName, @Nullable String
tableType, boolean excludeReplacedSegments,
+ long startTimestamp, long endTimestamp, boolean excludeOverlapping) {
String url = StringUtil.join("/", _baseUrl, "segments", tableName);
+ String urlParameter = "";
Review Comment:
nit: replace it with `StringBuilder` approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
