Jackie-Jiang commented on code in PR #10410:
URL: https://github.com/apache/pinot/pull/10410#discussion_r1134448802
##########
pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentAggregationMultiValueQueriesTest.java:
##########
@@ -595,7 +595,7 @@ public void testFilteredAggregations() {
new DataSchema.ColumnDataType[]{DataSchema.ColumnDataType.LONG});
ResultTable expectedResultTable =
new ResultTable(expectedDataSchema, Collections.singletonList(new
Object[]{370236L}));
- QueriesTestUtils.testInterSegmentsResult(brokerResponse, 370236L, 0L, 0L,
400000L, expectedResultTable);
+ QueriesTestUtils.testInterSegmentsResult(brokerResponse, 370236L, 400000L,
0L, 400000L, expectedResultTable);
Review Comment:
This is expected because we do scan this number of docs to resolve `column3
> 0` (verified with query without the aggregated filter). The reason why it
shows as 0 before is because we don't track the scans for main filter in
`CombinedFilterOperator` (there is a TODO in
`BlockDocIdSet.toNonScanDocIdSet()`). With the change, we won't create the
`CombinedFilterOperator`, thus the scans can be correctly reported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
