walterddr commented on code in PR #10421:
URL: https://github.com/apache/pinot/pull/10421#discussion_r1137592476
##########
pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java:
##########
@@ -3054,15 +3067,88 @@ public void testExtractTableNamesFromNode() {
Assert.assertEquals(tableNames.get(3), "tbl4");
}
- private static SqlNodeAndOptions testSqlWithCustomSqlParser(String
sqlString) {
- try (StringReader inStream = new StringReader(sqlString)) {
- SqlParserImpl sqlParser = CalciteSqlParser.newSqlParser(inStream);
- SqlNodeList sqlNodeList = sqlParser.SqlStmtsEof();
- // Extract OPTION statements from sql.
- return CalciteSqlParser.extractSqlNodeAndOptions(sqlString, sqlNodeList);
- } catch (Exception e) {
- Assert.fail("test custom sql parser failed", e);
- return null;
- }
+ @Test
+ public void testJoin() {
+ String query = "SELECT T1.a, T2.b FROM T1 JOIN T2";
+ PinotQuery pinotQuery = CalciteSqlParser.compileToPinotQuery(query);
+ DataSource dataSource = pinotQuery.getDataSource();
+ Assert.assertNull(dataSource.getTableName());
+ Assert.assertNull(dataSource.getSubquery());
+ Assert.assertNotNull(dataSource.getJoin());
+ Join join = dataSource.getJoin();
+ Assert.assertEquals(join.getType(), JoinType.INNER);
+ Assert.assertEquals(join.getLeft().getTableName(), "T1");
+ Assert.assertEquals(join.getRight().getTableName(), "T2");
+ Assert.assertNull(join.getCondition());
+
+ query = "SELECT T1.a, T2.b FROM T1 JOIN T2 ON T1.key = T2.key";
+ pinotQuery = CalciteSqlParser.compileToPinotQuery(query);
+ dataSource = pinotQuery.getDataSource();
+ Assert.assertNull(dataSource.getTableName());
+ Assert.assertNull(dataSource.getSubquery());
+ Assert.assertNotNull(dataSource.getJoin());
+ join = dataSource.getJoin();
+ Assert.assertEquals(join.getType(), JoinType.INNER);
+ Assert.assertEquals(join.getLeft().getTableName(), "T1");
+ Assert.assertEquals(join.getRight().getTableName(), "T2");
+ Assert.assertEquals(join.getCondition(),
CalciteSqlParser.compileToExpression("T1.key = T2.key"));
+
+ query = "SELECT T1.a, T2.b FROM T1 FULL JOIN T2 ON T1.key = T2.key";
+ pinotQuery = CalciteSqlParser.compileToPinotQuery(query);
+ dataSource = pinotQuery.getDataSource();
+ Assert.assertNull(dataSource.getTableName());
+ Assert.assertNull(dataSource.getSubquery());
+ Assert.assertNotNull(dataSource.getJoin());
+ join = dataSource.getJoin();
+ Assert.assertEquals(join.getType(), JoinType.FULL);
+ Assert.assertEquals(join.getLeft().getTableName(), "T1");
+ Assert.assertEquals(join.getRight().getTableName(), "T2");
+ Assert.assertEquals(join.getCondition(),
CalciteSqlParser.compileToExpression("T1.key = T2.key"));
+
+ query = "SELECT T1.a, T2.b FROM T1 LEFT JOIN T2 ON T1.a > T2.b";
+ pinotQuery = CalciteSqlParser.compileToPinotQuery(query);
+ dataSource = pinotQuery.getDataSource();
+ Assert.assertNull(dataSource.getTableName());
+ Assert.assertNull(dataSource.getSubquery());
+ Assert.assertNotNull(dataSource.getJoin());
+ join = dataSource.getJoin();
+ Assert.assertEquals(join.getType(), JoinType.LEFT);
+ Assert.assertEquals(join.getLeft().getTableName(), "T1");
+ Assert.assertEquals(join.getRight().getTableName(), "T2");
+ Assert.assertEquals(join.getCondition(),
CalciteSqlParser.compileToExpression("T1.a > T2.b"));
+
+ query =
+ "SELECT T1.a, T2.b FROM T1 RIGHT JOIN (SELECT a, COUNT(*) AS b FROM T3
GROUP BY a) AS T2 ON T1.key = T2.key";
+ pinotQuery = CalciteSqlParser.compileToPinotQuery(query);
+ dataSource = pinotQuery.getDataSource();
+ Assert.assertNull(dataSource.getTableName());
+ Assert.assertNull(dataSource.getSubquery());
+ Assert.assertNotNull(dataSource.getJoin());
+ join = dataSource.getJoin();
+ Assert.assertEquals(join.getType(), JoinType.RIGHT);
+ Assert.assertEquals(join.getLeft().getTableName(), "T1");
+ DataSource right = join.getRight();
+ Assert.assertEquals(right.getTableName(), "T2");
+ PinotQuery rightSubquery = right.getSubquery();
+ Assert.assertEquals(rightSubquery,
+ CalciteSqlParser.compileToPinotQuery("SELECT a, COUNT(*) AS b FROM T3
GROUP BY a"));
+ Assert.assertEquals(join.getCondition(),
CalciteSqlParser.compileToExpression("T1.key = T2.key"));
+
+ query =
+ "SELECT T1.a, T2.b FROM T1 JOIN (SELECT a, COUNT(*) AS b FROM T3 JOIN
T4 GROUP BY a) AS T2 ON T1.key = T2.key";
Review Comment:
this query is invalid right? the result of T2 doesn't have key column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
