walterddr commented on code in PR #10432:
URL: https://github.com/apache/pinot/pull/10432#discussion_r1137981097
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -72,6 +75,7 @@ public void send(TransferableBlock block)
@Override
public void complete()
throws Exception {
+ // TODO: should wait for _mailboxContentStreamObserver.onNext() finish
before calling onComplete().
Review Comment:
I think currently it is guaranteed that onComplete is called after all
onNext() --> implicitly via the OpChain scheduler. however we should still fix
this systematically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
