jadami10 opened a new pull request, #10444:
URL: https://github.com/apache/pinot/pull/10444
This is a minor `performance` `bugfix`.
1. this fixes NullPointerExceptions in existing optimizers when performing
`WHERE 1=1` queries. These would fail because the filter expression had no
function call
2. I noticed that `WHERE 1=1` was no simplified, but `WHERE col1>0 AND 1=1`
was actually being simplified in the `NumericalFilterOptimizer`. So I put that
part in a separate class to be used more generally for future cases like this
- it does a little more work than expected once it sees and AND/OR/NOT
expression
- something else is converting 1=1 to literal TRUE, but I'm not sure
where that is
3. This adds a `IdenticalPredicateFilterOptimizer` class that converts
`WHERE 1=1` or `WHERE "colA"!="colA"` to TRUE/FALSE respectively
I've added a bunch more test cases, and I've tested manually in the
Quickstart app. This is my first contribution to the query parsing part of the
code base, so I don't have a great sense what test coverage looks like. But I
imagine between unit and integration tests, this should catch any glaring
breaks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
