npawar commented on code in PR #10441:
URL: https://github.com/apache/pinot/pull/10441#discussion_r1143713181
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableConfigsRestletResource.java:
##########
@@ -304,8 +304,10 @@ public ConfigSuccessResponse updateConfig(
@ApiParam(value = "comma separated list of validation type(s) to skip.
supported types: (ALL|TASK|UPSERT)")
@QueryParam("validationTypesToSkip") @Nullable String typesToSkip,
@ApiParam(value = "Reload the table if the new schema is backward
compatible") @DefaultValue("false")
- @QueryParam("reload") boolean reload, String tableConfigsStr)
- throws Exception {
+ @QueryParam("reload") boolean reload,
Review Comment:
Please add to the javadocs, about this new config and when to use/use
cautiously.
Update the API note too, to indicate that this is to be used cautiously and
that it's the user's responsibility to make segments compatible again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
