walterddr commented on code in PR #10450:
URL: https://github.com/apache/pinot/pull/10450#discussion_r1144920736


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java:
##########
@@ -64,8 +64,9 @@ public TransferableBlock nextBlock() {
     try (InvocationScope ignored = 
Tracing.getTracer().createScope(getClass())) {
       _operatorStats.startTimer();
       TransferableBlock nextBlock = getNextBlock();
+      _operatorStats.endTimer(nextBlock);

Review Comment:
   we dont have any tests for MultiStageOperator stats and trace. it is good to 
add a collection of these



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to