walterddr commented on code in PR #10455: URL: https://github.com/apache/pinot/pull/10455#discussion_r1145193210
########## pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java: ########## @@ -105,6 +106,8 @@ public class BrokerRoutingManager implements RoutingManager, ClusterChangeHandle private String _idealStatePathPrefix; private String _instanceConfigsPath; private ZkHelixPropertyStore<ZNRecord> _propertyStore; + // TODO: Entries are never removed from map + private Map<String, SegmentZkMetadataCache> _segmentMetadataCacheMap; Review Comment: good catch. i originally put it in here but decided to merge it with routingEntry. this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
