jugomezv commented on code in PR #10418:
URL: https://github.com/apache/pinot/pull/10418#discussion_r1146815948
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/MessageBatch.java:
##########
@@ -116,4 +116,12 @@ default StreamPartitionMsgOffset getOffsetOfNextBatch() {
default boolean isEndOfPartitionGroup() {
return false;
}
+
+ /**
+ * We need this to determine ingestion delay when we receive only null
messages (Tombstone messages)
+ * @return last metadata for a null message received by the string
+ */
+ default public StreamMessageMetadata getLastTombstoneMetadata() {
Review Comment:
Agreed with removal of tobstone
s/filtered/unfiltered/
I agree with last comment, I think we should retain the last metadata for
the batch, that makes it more generic and less specific. I have done the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
