Jackie-Jiang commented on code in PR #10476:
URL: https://github.com/apache/pinot/pull/10476#discussion_r1148222477
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java:
##########
@@ -302,8 +302,13 @@ Map<String, List<Operation>>
computeOperations(SegmentDirectory.Reader segmentRe
}
// Note that RAW columns cannot be sorted.
+ // TODO: revisit the the possibility of converting noDictionary ->
Dictionary when the column is sorted.
ColumnMetadata existingColMetadata =
_segmentDirectory.getSegmentMetadata().getColumnMetadataFor(column);
- Preconditions.checkState(!existingColMetadata.isSorted(), "Raw
column=" + column + " cannot be sorted.");
+ if (existingColMetadata.isSorted()) {
+ LOGGER.warn("Raw column={} cannot be sorted and the dictionary won't
be created. Falling back to use "
+ + "noDictionaryColumn..", column);
+ continue;
+ }
Review Comment:
I think we can remove the whole check. This check itself doesn't provide
extra value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
