navina commented on code in PR #10484:
URL: https://github.com/apache/pinot/pull/10484#discussion_r1149684929
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java:
##########
@@ -256,6 +258,16 @@ public TableConfigBuilder
setInvertedIndexColumns(List<String> invertedIndexColu
return this;
}
+ public TableConfigBuilder setOptimizeDictionaryForMetrics(boolean
optimizeDictionaryForMetrics) {
+ _optimizeDictionaryForMetrics = optimizeDictionaryForMetrics;
+ return this;
+ }
+
+ public TableConfigBuilder setNoDictionarySizeRatioThreshold(double
noDictionarySizeRatioThreshold) {
Review Comment:
This naming is pretty confusing.
"sizeThresholdForNoDictionary" or "ratioForNoDictionary" ?
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java:
##########
@@ -103,6 +103,8 @@ public class TableConfigBuilder {
private List<StarTreeIndexConfig> _starTreeIndexConfigs;
private List<String> _jsonIndexColumns;
private boolean _aggregateMetrics;
+ private boolean _optimizeDictionaryForMetrics;
Review Comment:
`_noDictionarySizeRatioThreshold` is accepted only when
`_optimizeDictionaryForMetrics` is set as `true`?
Can you clarify the dependency on these configs, if any? Perhaps add
javadocs here so the next contributors understand the relationship.
We don't have a good way to document configs atm. javadocs can help in the
interim
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
