gortiz commented on code in PR #10184:
URL: https://github.com/apache/pinot/pull/10184#discussion_r1150551137
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##########
@@ -363,7 +314,7 @@ private boolean
createDictionaryForColumn(ColumnIndexCreationInfo info, SegmentG
private boolean
shouldCreateDictionaryWithinThreshold(ColumnIndexCreationInfo info,
SegmentGeneratorConfig config, FieldSpec spec) {
- long dictionarySize = info.getDistinctValueCount() *
spec.getDataType().size();
+ long dictionarySize = info.getDistinctValueCount() * (long)
spec.getDataType().size();
Review Comment:
Added in https://github.com/apache/pinot/pull/10492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
