gortiz commented on code in PR #10184:
URL: https://github.com/apache/pinot/pull/10184#discussion_r1151604829
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java:
##########
@@ -455,12 +458,16 @@ private void
rewriteRawMVForwardIndexForCompressionChange(String column, ColumnM
int maxRowLengthInBytes =
MultiValueVarByteRawIndexCreator.getMaxRowDataLengthInBytes(lengthOfLongestEntry,
maxNumberOfMVEntries);
- IndexCreationContext.Forward context =
-
IndexCreationContext.builder().withIndexDir(indexDir).withColumnMetadata(existingColMetadata)
-
.withLengthOfLongestEntry(lengthOfLongestEntry).withMaxRowLengthInBytes(maxRowLengthInBytes).build()
- .forForwardIndex(newCompressionType,
_indexLoadingConfig.getColumnProperties());
+ IndexCreationContext context = IndexCreationContext.builder()
Review Comment:
No, I changed them manually.
To break lines is very common when using fluent APIs (like java streams or
builders) and it is accepted by Google's style guide
([link](https://google.github.io/styleguide/javaguide.html#s4.5-line-wrapping),
specially the note).
I'm 100% sure that anyone will understand better the code with line-wraps
than the other where each line contains different number of method calls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
