walterddr commented on code in PR #10461:
URL: https://github.com/apache/pinot/pull/10461#discussion_r1152509846
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##########
@@ -478,20 +486,35 @@ public synchronized void buildRouting(String
tableNameWithType) {
Set<String> offlineTablePreSelectedOnlineSegments =
offlineTableSegmentPreSelector.preSelect(offlineTableOnlineSegments);
TimeBoundaryManager offlineTableTimeBoundaryManager =
- new TimeBoundaryManager(offlineTableConfig, _propertyStore,
_brokerMetrics);
- offlineTableTimeBoundaryManager.init(offlineTableIdealState,
offlineTableExternalView,
- offlineTablePreSelectedOnlineSegments);
-
offlineTableRoutingEntry.setTimeBoundaryManager(offlineTableTimeBoundaryManager);
+ new TimeBoundaryManager(offlineTableConfig, schema,
_brokerMetrics);
+
offlineTableRoutingEntry.initTimeBoundaryManager(offlineTableTimeBoundaryManager,
offlineTableIdealState,
+ offlineTableExternalView, offlineTablePreSelectedOnlineSegments);
Review Comment:
chatted offline with @Jackie-Jiang ^ we decided to leave timboundary out of
the segment zk metadata fetcher.
1. timeboundary manager is init separately and can have different timing
than the rest of the zk required utilities.
2. it is very possible that during server start up no zk metadata fetcher is
needed (e.g. no pruner and others).
- enabling this by default on all table is a waste
- merging this with the rest will possible cause duplicate init and slow
down server start up
will comment on the javadoc to make sure this knowledge is documented after
the PR is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
