saurabhd336 commented on code in PR #10184:
URL: https://github.com/apache/pinot/pull/10184#discussion_r1153024210
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/virtualcolumn/VirtualColumnIndexContainer.java:
##########
@@ -46,53 +44,18 @@ public VirtualColumnIndexContainer(ForwardIndexReader<?>
forwardIndex, InvertedI
_dictionary = dictionary;
}
+ @Nullable
@Override
- public ForwardIndexReader<?> getForwardIndex() {
- return _forwardIndex;
- }
-
- @Override
- public InvertedIndexReader<?> getInvertedIndex() {
- return _invertedIndex;
- }
-
- @Override
- public RangeIndexReader<?> getRangeIndex() {
- return null;
- }
-
- @Override
- public TextIndexReader getTextIndex() {
- return null;
- }
-
- @Override
- public TextIndexReader getFSTIndex() {
- return null;
- }
-
- @Override
- public JsonIndexReader getJsonIndex() {
- return null;
- }
-
- @Override
- public H3IndexReader getH3Index() {
- return null;
- }
-
- @Override
- public Dictionary getDictionary() {
- return _dictionary;
- }
-
- @Override
- public BloomFilterReader getBloomFilter() {
- return null;
- }
-
- @Override
- public NullValueVectorReader getNullValueVector() {
+ public <I extends IndexReader, T extends IndexType<?, I, ?>> I getIndex(T
indexType) {
Review Comment:
Could we do similar to PhysicalColumnIndexCreator and have a map<IndexTyoe,
Reader>?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
