gortiz commented on code in PR #10184:
URL: https://github.com/apache/pinot/pull/10184#discussion_r1153363591
##########
pinot-tools/src/main/java/org/apache/pinot/tools/segment/converter/DictionaryToRawIndexConverter.java:
##########
@@ -317,7 +317,7 @@ private void convertOneColumn(IndexSegment segment, String
column, File newSegme
int numDocs = segment.getSegmentMetadata().getTotalDocs();
int lengthOfLongestEntry = (storedType == DataType.STRING) ?
getLengthOfLongestEntry(dictionary) : -1;
- try (ForwardIndexCreator rawIndexCreator = DefaultIndexCreatorProvider
+ try (ForwardIndexCreator rawIndexCreator = ForwardIndexCreatorFactory
Review Comment:
we _may_ do that. But I'm not sure about the implications, given that here
we call a very specific method. I'm not sure if by calling
`StandardIndexes.forward()` we would end up calling the same method or not.
In this very low level classes I don't think we need to call the generic
code. The main advantage of calling the generic method is that in future we may
add the index overload feature. But that may be problematic, as the invariants
we assume in this low level classes may not be the same as the ones granted by
new implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
