Jackie-Jiang commented on code in PR #10510:
URL: https://github.com/apache/pinot/pull/10510#discussion_r1153849848
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java:
##########
@@ -205,7 +202,7 @@ private TableDataManager createTableDataManager(String
tableNameWithType, TableC
public void deleteTable(String tableNameWithType)
throws Exception {
// Wait externalview to converge
- long endTimeMs = System.currentTimeMillis() +
EXTERNAL_VIEW_DROPPED_MAX_WAIT_MS;
+ long endTimeMs = System.currentTimeMillis() +
_instanceDataManagerConfig.getExternalViewDroppedMaxWaitMs();
Review Comment:
(minor) Let's cache these 2 values into local variable (or as member
variable during `init()`)
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java:
##########
@@ -128,10 +128,17 @@ public class HelixInstanceDataManagerConfig implements
InstanceDataManagerConfig
private static final String DELETED_SEGMENTS_CACHE_TTL_MINUTES =
"table.deleted.segments.cache.ttl.minutes";
private static final String PEER_DOWNLOAD_SCHEME = "peer.download.scheme";
+ // Check if the external view is dropped for a table, and if so, wait for
the external view to
+ // be updated for a maximum of this time.
+ private static final String EXTERNAL_VIEW_DROPPED_MAX_WAIT_MS =
"external.view.dropped.max.wait.ms";
+ private static final String EXTERNAL_VIEW_CHECK_INTERVAL_MS =
"external.view.check.interval.ms";
Review Comment:
(minor)
```suggestion
private static final String EXTERNAL_VIEW_DROPPED_CHECK_INTERVAL_MS =
"external.view.dropped.check.interval.ms";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
