This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new bde66ebdb9 Enhance error reporting (#10531)
bde66ebdb9 is described below
commit bde66ebdb9d1b73b72b7b182d89377fd4332fb40
Author: Jia Guo <[email protected]>
AuthorDate: Mon Apr 3 14:12:18 2023 -0700
Enhance error reporting (#10531)
---
.../apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java | 5 +++--
.../java/org/apache/pinot/core/transport/InstanceRequestHandler.java | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git
a/pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
b/pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
index 07f6329a8a..1442a9ec2b 100644
---
a/pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
+++
b/pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
@@ -270,10 +270,11 @@ public class ServerQueryExecutorV1Impl implements
QueryExecutor {
// return the error table to broker sooner than here. But in case of
race condition, we construct the error
// table here too.
instanceResponse.addException(QueryException.getException(QueryException.QUERY_CANCELLATION_ERROR,
- "Query cancelled on: " + _instanceDataManager.getInstanceId() +
e));
+ "Query cancelled on: " + _instanceDataManager.getInstanceId() + "
" + e));
} else {
LOGGER.error("Exception processing requestId {}", requestId, e);
-
instanceResponse.addException(QueryException.getException(QueryException.QUERY_EXECUTION_ERROR,
e));
+
instanceResponse.addException(QueryException.getException(QueryException.QUERY_EXECUTION_ERROR,
+ "Query execution error on: " +
_instanceDataManager.getInstanceId() + " " + e));
}
} finally {
for (SegmentDataManager segmentDataManager : segmentDataManagers) {
diff --git
a/pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java
b/pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java
index 480b9b0427..e64322e711 100644
---
a/pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java
+++
b/pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java
@@ -283,9 +283,10 @@ public class InstanceRequestHandler extends
SimpleChannelInboundHandler<ByteBuf>
dataTableMetadata.put(MetadataKey.REQUEST_ID.getName(),
Long.toString(requestId));
if (cancelled) {
dataTable.addException(QueryException.getException(QueryException.QUERY_CANCELLATION_ERROR,
- "Query cancelled on: " + _instanceName + e));
+ "Query cancelled on: " + _instanceName + " " + e));
} else {
-
dataTable.addException(QueryException.getException(QueryException.QUERY_EXECUTION_ERROR,
e));
+
dataTable.addException(QueryException.getException(QueryException.QUERY_EXECUTION_ERROR,
+ "Query execution error on: " + _instanceName + " " + e));
}
byte[] serializedDataTable = dataTable.toBytes();
sendResponse(ctx, tableNameWithType, queryArrivalTimeMs,
serializedDataTable);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
