walterddr commented on code in PR #10447:
URL: https://github.com/apache/pinot/pull/10447#discussion_r1156712247
##########
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/ExecutionStatsAggregator.java:
##########
@@ -363,19 +362,20 @@ public void setStats(@Nullable String rawTableName,
BrokerResponseNative brokerR
public void setStageLevelStats(@Nullable String rawTableName,
BrokerResponseStats brokerResponseStats,
@Nullable BrokerMetrics brokerMetrics) {
- setStats(rawTableName, brokerResponseStats, brokerMetrics);
-
- brokerResponseStats.setNumBlocks(_numBlocks);
- brokerResponseStats.setNumRows(_numRows);
- brokerResponseStats.setStageExecutionTimeMs(_stageExecutionTimeMs);
- brokerResponseStats.setStageExecWallTimeMs(_stageExecEndTimeMs -
_stageExecStartTimeMs);
- brokerResponseStats.setStageExecutionUnit(_stageExecutionUnit);
Review Comment:
shouldn't stage execution start/end time be set? as well as the num
row/blocks?
Let's rename this to operator execution time instead if that's confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
