walterddr commented on code in PR #10559:
URL: https://github.com/apache/pinot/pull/10559#discussion_r1159260062
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java:
##########
@@ -181,6 +182,9 @@ protected void compareRowEquals(List<Object[]> resultRows,
List<Object[]> expect
}
return Double.compare(ld, rd);
} else if (l instanceof String) {
+ if (r instanceof byte[]) {
Review Comment:
ah. got it... so we want to make it hex string. that sound like a good plan.
let's add a comment here explaining the reason why.
(also what's the default postgres behavior? should we follow that and make
the rendering code convert to hex?) what's the expected behavior on JDBC?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
