ankitsultana commented on code in PR #10570:
URL: https://github.com/apache/pinot/pull/10570#discussion_r1160322509
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/PhysicalPlanVisitor.java:
##########
@@ -61,12 +63,20 @@ public static OpChain build(StageNode node,
PlanRequestContext context) {
@Override
public MultiStageOperator visitMailboxReceive(MailboxReceiveNode node,
PlanRequestContext context) {
- MailboxReceiveOperator mailboxReceiveOperator =
- new MailboxReceiveOperator(context.getOpChainExecutionContext(),
node.getExchangeType(),
- node.getCollationKeys(), node.getCollationDirections(),
node.isSortOnSender(), node.isSortOnReceiver(),
- node.getDataSchema(), node.getSenderStageId(), node.getStageId());
- context.addReceivingMailboxes(mailboxReceiveOperator.getSendingMailbox());
- return mailboxReceiveOperator;
+ if (!CollectionUtils.isEmpty(node.getCollationKeys()) &&
node.isSortOnReceiver()) {
Review Comment:
Yeah makes sense.
Should we change this condition to simply: `node.isSortOnReceiver()` and add
a precondition under the if block? Might be helpful to catch bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
