somandal commented on code in PR #10570:
URL: https://github.com/apache/pinot/pull/10570#discussion_r1160414628
##########
pinot-query-planner/src/test/resources/queries/BasicQueryPlans.json:
##########
@@ -39,7 +39,7 @@
"Execution Plan",
"\nLogicalProject(EXPR$0=[dateTrunc('DAY', $4)])",
"\n LogicalSort(offset=[0], fetch=[10])",
- "\n PinotLogicalSortExchange(distribution=[hash], collation=[[]],
isSortOnSender=[false], isSortOnReceiver=[true])",
+ "\n PinotLogicalSortExchange(distribution=[hash], collation=[[]],
isSortOnSender=[false], isSortOnReceiver=[false])",
Review Comment:
yes that's essentially why i decided to modify the sort exchange used for
LogicalSort nodes to check collation keys to decide whether to sort or not. The
operator was already handling this earlier (i.e. checked for both
isSortedOnReceiver flag and collation key to perform sorting), this changes
makes this explicit in the planner side itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
