xiangfu0 commented on code in PR #10583:
URL: https://github.com/apache/pinot/pull/10583#discussion_r1161151652
##########
pinot-core/src/test/java/org/apache/pinot/core/common/datatable/DataTableSerDeTest.java:
##########
@@ -123,36 +123,142 @@ public void testException(int dataTableVersion)
}
@Test(dataProvider = "versionProvider")
- public void testEmptyStrings(int dataTableVersion)
+ public void testEmptyValues(int dataTableVersion)
throws IOException {
DataTableBuilderFactory.setDataTableVersion(dataTableVersion);
String emptyString = StringUtils.EMPTY;
String[] emptyStringArray = {StringUtils.EMPTY};
+ ByteArray emptyBytes = new ByteArray(new byte[0]);
+ for (int numRows = 0; numRows < NUM_ROWS; numRows++) {
+ testEmptyValues(new DataSchema(new String[]{"STR_SV", "STR_MV"}, new
DataSchema.ColumnDataType[]{
Review Comment:
We don't really use `OBJECT` type anywhere and what is an empty `OBJECT` if
not null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
