jadami10 commented on PR #10584:
URL: https://github.com/apache/pinot/pull/10584#issuecomment-1502042214
> One less common example that IMO can lead to surprising behavior is:
>
> ```
> {
> enabled: null
> }
> ```
>
> The above example will actually enable the index
It's surprising, but I think it's still better. If you're configuring an
index in any way, you probably already want it on. And if you don't want it on,
you're either going to delete the entire block, or explicitly set `"enabled":
false`.
As for enabled vs disabled, was this a new a field, or did it already exist?
Because if it existed, wouldn't this be a big breaking change now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
