KKcorps commented on code in PR #10575:
URL: https://github.com/apache/pinot/pull/10575#discussion_r1165942119
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/SelectTupleElementTransformFunction.java:
##########
@@ -84,6 +87,23 @@ public String getName() {
return _name;
}
+ @Override
+ public RoaringBitmap getNullBitmap(ValueBlock valueBlock) {
+ RoaringBitmap bitmap = _arguments.get(0).getNullBitmap(valueBlock);
+ for (int i = 1; i < _arguments.size(); i++) {
+ RoaringBitmap curBitmap = _arguments.get(i).getNullBitmap(valueBlock);
+ if (bitmap != null && curBitmap != null) {
+ bitmap.and(curBitmap);
+ } else {
+ bitmap = null;
+ }
+ }
+ if (bitmap == null || bitmap.isEmpty()) {
Review Comment:
This check can be implemented before for loop as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
