Jackie-Jiang commented on code in PR #10602:
URL: https://github.com/apache/pinot/pull/10602#discussion_r1165995898
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java:
##########
@@ -235,6 +236,15 @@ public void deleteTable(String tableNameWithType)
throws Exception {
// Wait externalview to converge
long endTimeMs = System.currentTimeMillis() +
_externalViewDroppedMaxWaitMs;
+ _tableDataManagerMap.compute(tableNameWithType, (k, v) -> {
Review Comment:
Don't use `compute()` here. `get()` should be enough. Currently this compute
will remove the table data manager, preventing it being shut down when external
view is removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
