Jackie-Jiang commented on code in PR #10536: URL: https://github.com/apache/pinot/pull/10536#discussion_r1167110972
########## pinot-spi/src/main/java/org/apache/pinot/spi/annotations/segment/lifecycle/SegmentDeletionListener.java: ########## @@ -0,0 +1,32 @@ + + +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.annotations.segment.lifecycle; + +import java.lang.annotation.ElementType; +import java.lang.annotation.Retention; +import java.lang.annotation.RetentionPolicy; +import java.lang.annotation.Target; + +@Retention(RetentionPolicy.RUNTIME) +@Target(ElementType.TYPE) +public @interface SegmentDeletionListener { Review Comment: @mcvsubbu You are right. We should put the interfaces together and ideally put them into `spi` so that people only need to pull `spi` dependency when adding plug-ins. That is not possible right now because `HelixManager` is not included in `spi`. We can probably move them into `common` as of now. @saurabhd336 wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
