Jackie-Jiang commented on code in PR #10612:
URL: https://github.com/apache/pinot/pull/10612#discussion_r1167286363
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/ClusterIntegrationTestUtils.java:
##########
@@ -903,25 +900,21 @@ private static void
comparePinotResultsWithExpectedValues(Set<String> expectedVa
}
private static String removeTrailingZeroForNumber(String value, String type)
{
+ String upperCaseType = StringUtils.toUpperCase(type);
Review Comment:
```suggestion
String upperCaseType = type.toUpperCase();
```
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/ClusterIntegrationTestUtils.java:
##########
@@ -163,7 +163,7 @@ public static void setUpH2TableWithAvro(List<File>
avroFiles, String tableName,
params.append(",?");
}
PreparedStatement h2Statement =
- h2Connection.prepareStatement("INSERT INTO " + tableName + " VALUES ("
+ params.toString() + ")");
+ h2Connection.prepareStatement("INSERT INTO " + tableName + " VALUES ("
+ params.toString() + ")");;
Review Comment:
Revert
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/ClusterIntegrationTestUtils.java:
##########
@@ -55,6 +55,7 @@
import org.apache.avro.io.BinaryEncoder;
import org.apache.avro.io.EncoderFactory;
import org.apache.avro.util.Utf8;
+import org.apache.hadoop.util.StringUtils;
Review Comment:
We don't tend to use this library
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
