Jackie-Jiang commented on code in PR #10629:
URL: https://github.com/apache/pinot/pull/10629#discussion_r1170388852


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -42,18 +42,19 @@
  */
 public class GrpcSendingMailbox implements SendingMailbox<TransferableBlock> {
   private static final Logger LOGGER = 
LoggerFactory.getLogger(GrpcSendingMailbox.class);
-  private final String _mailboxId;
-  private final AtomicBoolean _initialized = new AtomicBoolean(false);
 
-  private StreamObserver<MailboxContent> _mailboxContentStreamObserver;
+  private final String _mailboxId;

Review Comment:
   I kept it as string here because we need to include it as string in the 
mailbox content. This can avoid serializing it multiple times



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to