walterddr commented on code in PR #10535:
URL: https://github.com/apache/pinot/pull/10535#discussion_r1171609231
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/ShuffleRewriteVisitor.java:
##########
@@ -79,6 +80,16 @@ public Set<Integer> visitWindow(WindowNode node, Void
context) {
throw new UnsupportedOperationException("Window not yet supported!");
}
+ @Override
+ public Set<Integer> visitSetOp(SetOpNode setOpNode, Void context) {
+ StageNode firstInput = setOpNode.getInputs().get(0);
+ if (firstInput instanceof ProjectNode) {
+ Set<Integer> oldPartitionKeys = firstInput.visit(this, context);
+ return deriveNewPartitionKeysFromRexExpressions(((ProjectNode)
firstInput).getProjects(), oldPartitionKeys);
+ }
Review Comment:
what's the rational behind this? and was this tested? i don't think this is
being used at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
