swaminathanmanish commented on code in PR #10630:
URL: https://github.com/apache/pinot/pull/10630#discussion_r1171692325


##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/SegmentConversionUtils.java:
##########
@@ -200,18 +201,21 @@ public static String startSegmentReplace(String 
tableNameWithType, String upload
     }
   }
 
-  public static void endSegmentReplace(String tableNameWithType, String 
uploadURL, String segmentLineageEntryId,
-      int socketTimeoutMs, @Nullable AuthProvider authProvider)
+  public static void endSegmentReplace(String tableNameWithType, String 
uploadURL,

Review Comment:
   Ok, added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to