navina commented on code in PR #10638:
URL: https://github.com/apache/pinot/pull/10638#discussion_r1171702104


##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ConnectionTimeouts.java:
##########
@@ -25,18 +25,26 @@ public class ConnectionTimeouts {
     private final int _readTimeoutMs;
     private final int _connectTimeoutMs;
     private final int _handshakeTimeoutMs;
+    private final Integer _requestTimeoutMs;

Review Comment:
   I see. In that case, you can just drop in the default request timeout in the 
constructor, instead of using null.
   ```
     # Replace
           return create(readTimeoutMs, connectTimeoutMs, handshakeTimeoutMs, 
null);
    # with 
           return create(readTimeoutMs, connectTimeoutMs, handshakeTimeoutMs, 
60 * 1000);
   ```
   
   This will keep it backwards compatible and flexible. I would like to avoid 
unnecessary boxing/unboxing due to Integer object type. Feels unnecessary. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to