gortiz opened a new pull request, #10653: URL: https://github.com/apache/pinot/pull/10653
As explained in #10652, nullability is not actually applied per column but to the whole table. Before this PR, NullValueIndexType followed the same pattern common pattern where first it tries to check if it is configured in `fieldConfigList.indexes` and if it is not, it delegates into the other way to configure them. In this case, the other way is to set `tableIndexConfg.nullHandlingEnabled` to true. But even if NullValueIndexType open the possibility of setting nullability per column, the rest of the code is not prepared to do that. I've opened #10652 in order to discuss if we want to add that feature and how to do that, but meanwhile, I think it is better to disable the option of selectively configure nullability per column, given that it is confusing. The PR also applies a small change in AbstractIndexType in order to improve error messages when indexes are defined using two different syntaxis. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
