abhioncbr commented on issue #10608:
URL: https://github.com/apache/pinot/issues/10608#issuecomment-1518368717

   Thanks, @siddharthteotia,  @GSharayu and @Jackie-Jiang, for the comments.
   
   I'm just asking the question here that I have asked on the draft PR. 
   What if a user provides a different `partitionColumn` value in both configs? 
As per @Jackie-Jiang's comment, we will use the value of `partitionColumn` 
provided in `InstanceReplicaGroupPartitionConfig`. Is it correct? Also, for 
`numInstancesPerPartition`, it's going to be the same?
   
   I was going over the 
[documentation](https://docs.pinot.apache.org/operators/operating-pinot/instance-assignment),
 and I think we need to update the documentation by mentioning 
`ReplicaGroupStrategyConfig ` as deprecated.
   
   Please let me know if anything else needs to be updated. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to