saurabhd336 commented on PR #10536: URL: https://github.com/apache/pinot/pull/10536#issuecomment-1518535479
@mcvsubbu @Jackie-Jiang 1) I saw value in letting this segment lifecycle event listener pattern be used across the board for getting notifications of any segment related event (reloading. tiering, addition, deletion etc.). I've updated the PR to make it more generic and allow for extending to other event types. LMK what you think. I can update accordingly. 2) Had a discussion with @Jackie-Jiang and since fetching ZK metadata for the segment / tables is likely a common task these listeners would perform, needed to initialize it with ZKManger. Which means these interfaces need to go in pinot-core. @mcvsubbu I know the general guidelines would dictate these interfaces to reside in spi, but the need to init with zk manager prohibits that here.. Could you please share your thoughts on this? If we do indeed keep it in SPI, we may think of not initializing via reflections and possibly somewhere inside controller start(). We might lose ability to plug in listerners in that case though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
