Jackie-Jiang commented on code in PR #10671:
URL: https://github.com/apache/pinot/pull/10671#discussion_r1174456270
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerMetadata.java:
##########
@@ -0,0 +1,14 @@
+package org.apache.pinot.query.routing;
+
+import java.util.List;
+import java.util.Map;
+
+
+public class WorkerMetadata {
+ private VirtualServerAddress _virtualServerAddress;
+
+ // used for table scan stage - we use ServerInstance instead of VirtualServer
+ // here because all virtual servers that share a server instance will have
the
+ // same segments on them
+ private List<Map<String, List<String>>> _segmentsList;
Review Comment:
What is the map here? Is this a pair of table name to list of segments?
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/StageMetadata.java:
##########
@@ -38,16 +39,13 @@
* <li>the server instances to which this stage should be execute on</li>
* </ul>
*/
-public class StageMetadata implements Serializable {
+public class StageMetadata {
private List<String> _scannedTables;
// used for assigning server/worker nodes.
- private List<VirtualServer> _serverInstances;
+ private Map<ServerInstance, List<Integer>> _serverToWorkerIdsMap;
Review Comment:
Do we need this map? Ideally we should already split the segments to the
worker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
