Jackie-Jiang commented on PR #10536: URL: https://github.com/apache/pinot/pull/10536#issuecomment-1518749576
The changes look good to me. Thanks for making it general, very clean implementation! @mcvsubbu Let me know if you have concerns. Because of the `Helix` dependency, we need to put it in `pinot-core` for now, but we can easily move it into the SPI when we introduce the `Helix` dependent SPI module -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
