siddharthteotia commented on code in PR #10683:
URL: https://github.com/apache/pinot/pull/10683#discussion_r1175931547
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -816,6 +816,9 @@ public static class Accounting {
public static final String CONFIG_OF_GC_WAIT_TIME_MS =
"accounting.gc.wait.time.ms";
public static final int DEFAULT_CONFIG_OF_GC_WAIT_TIME_MS = 0;
+
+ public static final String CONFIG_OF_QUERY_KILLED_METRIC_ENABLED =
"accounting.query.killed.metric.enabled";
+ public static final boolean DEFAULT_QUERY_KILLED_METRIC_ENABLED = false;
Review Comment:
Why is this change needed ?
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -816,6 +816,9 @@ public static class Accounting {
public static final String CONFIG_OF_GC_WAIT_TIME_MS =
"accounting.gc.wait.time.ms";
public static final int DEFAULT_CONFIG_OF_GC_WAIT_TIME_MS = 0;
+
+ public static final String CONFIG_OF_QUERY_KILLED_METRIC_ENABLED =
"accounting.query.killed.metric.enabled";
+ public static final boolean DEFAULT_QUERY_KILLED_METRIC_ENABLED = false;
Review Comment:
and why is this set to false ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
