walterddr commented on code in PR #10685:
URL: https://github.com/apache/pinot/pull/10685#discussion_r1178002040
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/queries/ResourceBasedQueriesTest.java:
##########
@@ -375,9 +375,13 @@ private static Object[][]
testResourceQueryTestCaseProviderWithMetadata()
: replaceTableName(testCaseName, queryCase._sql);
int segmentCount = 0;
- for (String tableName : testCaseEntry.getValue()._tables.keySet()) {
- segmentCount +=
- _tableToSegmentMap.getOrDefault(testCaseName + "_" + tableName
+ "_OFFLINE", new HashSet<>()).size();
+ if (queryCase._expectedNumSegments != null) {
Review Comment:
hmm. I am not sure this is the right way to test. a simple final result
check should already be sufficient (if not we should make the test case so that
it is impossible to do it other than running 2 joins)
but for now i think this would be useful
- in the future we want to assert segment pruner behavior
- if we were to use this for the table scan twice purpose please add a
`"comment"` in the JSON to indicate so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
