kishoreg commented on code in PR #10673:
URL: https://github.com/apache/pinot/pull/10673#discussion_r1179644454
##########
pinot-common/src/main/proto/worker.proto:
##########
@@ -70,23 +70,17 @@ message QueryResponse {
message StagePlan {
int32 stageId = 1;
- string instanceId = 2;
+ string virtualAddress = 2;
StageNode stageRoot = 3;
- map<int32, StageMetadata> stageMetadata = 4;
+ repeated StageMetadata stageMetadata = 4;
}
message StageMetadata {
Review Comment:
Also, a stage having multiple stageNode is a bit confusing.. should we call
this StagePlan?
StageMetadata is really StagePlan Metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
