KKcorps commented on code in PR #9713:
URL: https://github.com/apache/pinot/pull/9713#discussion_r1180427040
##########
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisStreamMetadataProvider.java:
##########
@@ -189,6 +192,24 @@ private boolean
consumedEndOfShard(StreamPartitionMsgOffset startCheckpoint,
}
@Override
- public void close() {
+ public Map<String, PartitionLagState> getCurrentPartitionLagState(
+ Map<String, ConsumerPartitionState> currentPartitionStateMap) {
+ Map<String, PartitionLagState> perPartitionLag = new HashMap<>();
+ for (Map.Entry<String, ConsumerPartitionState> entry:
currentPartitionStateMap.entrySet()) {
+ ConsumerPartitionState partitionState = entry.getValue();
+ // Compute record-availability
+ String recordAvailabilityLag = "UNKNOWN";
+ RowMetadata lastProcessedMessageMetadata =
partitionState.getLastProcessedRowMetadata();
+ if (lastProcessedMessageMetadata != null &&
partitionState.getLastProcessedTimeMs() > 0) {
+ long availabilityLag = partitionState.getLastProcessedTimeMs()
+ - lastProcessedMessageMetadata.getRecordIngestionTimeMs();
+ recordAvailabilityLag = String.valueOf(availabilityLag);
+ }
+ perPartitionLag.put(entry.getKey(), new
KinesisConsumerPartitionLag(recordAvailabilityLag));
Review Comment:
IMO, we should be using this metric. Kinesis official dashboards also use
the same metric
[image](https://user-images.githubusercontent.com/5559703/235164581-f9c3a557-b425-4bc6-a4c0-759e76e082e0.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
