Jackie-Jiang commented on code in PR #10704:
URL: https://github.com/apache/pinot/pull/10704#discussion_r1182083960
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/UpsertUtils.java:
##########
@@ -177,26 +179,35 @@ public void close()
public static class MultiComparisonColumnReader implements
UpsertUtils.ComparisonColumnReader {
private final PinotSegmentColumnReader[] _comparisonColumnReaders;
+ private final NullValueVectorReader[] _comparisonColumnNullReaders;
Review Comment:
This is not needed. You may use `PinotSegmentColumnReader.isNull()` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
