Jackie-Jiang opened a new pull request, #10707: URL: https://github.com/apache/pinot/pull/10707
This bug was introduced in #9667 When the predicate matches all the non-star nodes under a branch, we can use the star-node if it exists and the dimension is not included in the remaining predicate and group-by. In the existing code we update the global remaining predicate too late, and the branches before the update can mistakenly use the star-node even though the dimension is included in the remaining predicate. This PR fixes that behavior by tracking whether we have added leaf node into the queue, so that we can update the global remaining predicate before traversing any child of that dimension. Added a hard-coded query in `StarTreeClusterIntegrationTest` to test this behavior. Also print the random seed when test fails to make it much easier to reproduce. This also fixes #9945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
