walterddr commented on code in PR #10708:
URL: https://github.com/apache/pinot/pull/10708#discussion_r1182643347
##########
pinot-common/src/main/proto/worker.proto:
##########
@@ -72,15 +72,28 @@ message StagePlan {
int32 stageId = 1;
string virtualAddress = 2;
StageNode stageRoot = 3;
- repeated StageMetadata stageMetadata = 4;
+ StageMetadata stageMetadata = 4;
}
message StageMetadata {
repeated WorkerMetadata workerMetadata = 1;
map<string, string> customProperty = 2;
+ map<int32, StageMailboxInfo> stageMailboxInfoMap = 3;
}
message WorkerMetadata {
string virtualAddress = 1;
map<string, string> customProperty = 2;
}
+
+message MailboxInfo {
+ string mailboxId = 1;
+ string mailboxType = 2;
+ string mailboxHost = 3;
+ int32 mailboxPort = 4;
+ map<string, string> customProperty = 5;
+}
+
+message StageMailboxInfo {
+ repeated MailboxInfo mailboxInfo = 1;
+}
Review Comment:
this makes hard to convert mailbox info going forward. I would suggest
directly modifying the WorkerMetadata
```
message WorkerMetadata {
string virtualAddress = 1;
map<int32, MailboxMetadata> mailboxMetadata = 2;
map<string, string> customProperty = 3;
}
message MailboxMetadata {
repeated string mailboxId = 1;
repeated string virtualAddress = 2;
map<string, string> customProperty = 3;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
